[Kst] branches/work/kst/portto4/kst

Adam Treat treat at kde.org
Tue Feb 20 19:36:35 CET 2007

SVN commit 635707 by treat:

* qSort algorithm is having problems with Q3ValueList
Comment out and note in PORTINGTODO so it isn't lost.

 M  +1 -0      PORTINGTODO  
 M  +2 -2      src/libkstmath/kstdataobject.cpp  

--- branches/work/kst/portto4/kst/PORTINGTODO #635706:635707
@@ -18,6 +18,7 @@
        use atomic reference counting.  See the threading docs...
     2. KstObjectList::findTag is broken for now as Q3ValueList does not have same semantics as
        QValueList had...
+    3. Numerous calls to qSort are commented out for now until switch from Q3ValueList
   C. Revamp the plugin manager to use Qt4's plugin system?
   D. We relied upon a hack in KDE3 version that used a private header
      from qt.  This is no longer installed in Qt4.  This can be taken care of by getting rid of
--- branches/work/kst/portto4/kst/src/libkstmath/kstdataobject.cpp #635706:635707
@@ -376,8 +376,8 @@
     outputs += (*i).data();
-  qSort(inputs);
-  qSort(outputs);
+//   qSort(inputs);
+//   qSort(outputs);
   Q3ValueList<KstPrimitivePtr>::ConstIterator inputIt = inputs.begin();
   Q3ValueList<KstPrimitivePtr>::ConstIterator outputIt = outputs.begin();

More information about the Kst mailing list