[Kst] [Bug 134686] crash when copying a plot from one window to another

George Staikos staikos at kde.org
Fri Sep 29 00:21:12 CEST 2006


------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.
         
http://bugs.kde.org/show_bug.cgi?id=134686         
staikos kde org changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |RESOLVED
         Resolution|                            |FIXED



------- Additional Comments From staikos kde org  2006-09-29 00:21 -------
SVN commit 589910 by staikos:

The fake copy constructor strikes again...  uninit variables were causing
invalid memory references.
I'm not sure if there are more cases of this.
BUG: 134686


 M  +4 -1      kst2dplot.cpp  


--- trunk/extragear/graphics/kst/src/libkstapp/kst2dplot.cpp #589909:589910
 @ -580,6 +580,9  @
   _xReversed = plot._xReversed;
   _yReversed = plot._yReversed;
 
+  _lineWidthMarkers = plot._lineWidthMarkers;
+  _lineStyleMarkers = plot._lineStyleMarkers;
+
   Curves = plot.Curves;
 }
 
 @ -5612,7 +5615,7  @
 void Kst2DPlot::plotPlotMarkers(KstPainter& p,
                            double m_X, double b_X, double x_max, double x_min,
                            double y_px, double ytop_bdr_px, double ybot_bdr_px) {
-  int width = lineWidthMarkers() * p.lineWidthAdjustmentFactor();
+  const int width = lineWidthMarkers() * p.lineWidthAdjustmentFactor();
 
   if (defaultColorMarker()) {
     p.setPen(QPen(foregroundColor(), width, KstLineStyle[lineStyleMarkers()]));


More information about the Kst mailing list