[Kst] branches/work/kst/pluginify/kst/src/extensions/js

George Staikos staikos at kde.org
Sat Sep 16 01:39:31 CEST 2006


On Friday 15 September 2006 17:56, Adam Treat wrote:
> SVN commit 584951 by treat:
>
> * Spotted a couple of Q_UNUSED's
>
> --- branches/work/kst/pluginify/kst/src/extensions/js/js.cpp #584950:584951
> @@ -326,10 +326,13 @@
>
>
>  void KstJS::load(QDomElement& e) {
> +  Q_UNUSED(e)
>  }
>
>
>  void KstJS::save(QTextStream& ts, const QString& indent) {
> +  Q_UNUSED(ts)
> +  Q_UNUSED(indent)
>  }

  Best to leave these as warnings since they're unimplemented code that should 
be implemented once we figure out what they're supposed to do.

  Also I think you should try to keep things unrelated to plugin changes out 
of this branch to make merging easier.  The other fixes in this were fine for 
trunk.

-- 
George Staikos
KDE Developer				http://www.kde.org/
Staikos Computing Services Inc.		http://www.staikos.net/


More information about the Kst mailing list