[Kst] extragear/graphics/kst/src/libkstapp

[George Staikos]

Yes, we need to understand which cases require setXScale/setYScale and move 
those calls to the right place, otherwise calling optimizeFoo() will set the 
scale unpredictably.

On Friday 20 October 2006 12:11, Barth Netterfield wrote:
> Any action required here other than the general 'at some point we should
> clean up kst2dplot'?
>
> cbn
>
> On Friday 20 October 2006 09:29, George Staikos wrote:
> > Hm yes, that was in my fix for expressions as axis values.  I'm not
> > surprised because the whole thing is a mess, but I think this fix is
> > wrong. First, refactoring an expression has nothing to do with setting
> > the axis scale, so it really shouldn't be in that function.  Second, I
> > think it's not entirely correct.  It will only happen if the axis scale
> > is an expression, and if it's required, it will be required for all
> > cases.  Maybe by coincidence it happens to work for some or all of the
> > other cases, but probably this call should go in popScale() and the plot
> > dialog.
> >
> > On Friday 20 October 2006 08:58, Barth Netterfield wrote:
> > > SVN commit 597466 by netterfield:
> > >
> > > BUG: 135992
> > >
> > > These lines got recently deleted... anyone know why?
> > >
> > >  M  +2 -0      kst2dplot.cpp
> > >
> > >
> > > --- trunk/extragear/graphics/kst/src/libkstapp/kst2dplot.cpp
> > > #597465:597466 @@ -6473,6 +6473,7 @@
> > >          min -= fabs(min) * 0.01;
> > >        }
> > >      }
> > > +    setXScale(min, max);
> > >    }
> > >  }
> > >
> > > @@ -6495,6 +6496,7 @@
> > >          min -= fabs(min) * 0.01;
> > >        }
> > >      }
> > > +    setYScale(min, max);
> > >    }
> > >  }
> > >
> > > _______________________________________________
> > > Kst mailing list
> > > Kst at kde.org
> > > https://mail.kde.org/mailman/listinfo/kst
>
> _______________________________________________
> Kst mailing list
> Kst at kde.org
> https://mail.kde.org/mailman/listinfo/kst

-- 
George Staikos
KDE Developer				http://www.kde.org/
Staikos Computing Services Inc.		http://www.staikos.net/