[Kst] [Bug 135440] Crash when a plugin is missing

George Staikos staikos at kde.org
Thu Oct 12 19:02:21 CEST 2006


------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.
         
http://bugs.kde.org/show_bug.cgi?id=135440         
staikos kde org changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|REOPENED                    |RESOLVED
         Resolution|                            |FIXED



------- Additional Comments From staikos kde org  2006-10-12 19:02 -------
SVN commit 594867 by staikos:

don't load invalid plugins at all
BUG: 135440


 M  +4 -2      kstdoc.cpp  


--- trunk/extragear/graphics/kst/src/libkstapp/kstdoc.cpp #594866:594867
 @ -381,8 +381,10  @
         KST::addVectorToList(KstVectorPtr(avector));
       } else if (e.tagName() == "plugin") {
         KstDataObjectPtr p = new KstPlugin(e);
-        KstWriteLocker dowl(&KST::dataObjectList.lock());
-        KST::dataObjectList.append(p);
+        if (p->isValid()) {
+          KstWriteLocker dowl(&KST::dataObjectList.lock());
+          KST::dataObjectList.append(p);
+        }
       } else if (e.tagName() == "curve") {
         KstDataObjectPtr p = new KstVCurve(e);
         KstWriteLocker dowl(&KST::dataObjectList.lock());


More information about the Kst mailing list