[Kst] [Bug 135343] Plugin output vectors have no name
netterfield at astro.utoronto.ca
netterfield at astro.utoronto.ca
Thu Oct 12 16:48:48 CEST 2006
------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.
http://bugs.kde.org/show_bug.cgi?id=135343
netterfield astro utoronto ca changed:
What |Removed |Added
----------------------------------------------------------------------------
Status|NEW |RESOLVED
Resolution| |FIXED
------- Additional Comments From netterfield astro utoronto ca 2006-10-12 16:48 -------
SVN commit 594845 by netterfield:
BUG: 135343
Nicolas seems correct: the fix was trivial (though surprising that it
was missing). Basically, the name was generated , but never used (?).
This should be back-ported to 1.3 - hopefully 1.3.1.
This code could use some re-arranging, but not for 1.3.
M +7 -0 kstplugindialog_i.cpp
--- trunk/extragear/graphics/kst/src/libkstapp/kstplugindialog_i.cpp #594844:594845
@ -497,6 +497,7 @
plugin->outputVectors().insert((*it)._name, v);
KST::addVectorToList(v);
}
+ v->setTagName(nt);
} else if (plugin->outputVectors()[(*it)._name]->tagName() != nt) {
while (KstData::self()->vectorTagNameNotUnique(nt, false)) {
nt += "'";
@ -510,6 +511,7 @
plugin->outputVectors().insert((*it)._name, v);
KST::addVectorToList(v);
}
+ v->setTagName(nt);
}
} else if ((*it)._type == Plugin::Data::IOValue::StringType) {
if (!KstData::self()->vectorTagNameNotUnique(nt, false)) {
@ -521,6 +523,8 @
s->writeLock();
plugin->outputStrings().insert((*it)._name, s);
}
+ s->setTagName(nt);
+
} else if (plugin->outputStrings()[(*it)._name]->tagName() != nt) {
while (KstData::self()->vectorTagNameNotUnique(nt, false)) {
nt += "'";
@ -533,6 +537,7 @
s->writeLock();
plugin->outputStrings().insert((*it)._name, s);
}
+ s->setTagName(nt);
}
} else if ((*it)._type == Plugin::Data::IOValue::PidType) {
// Nothing
@ -546,6 +551,7 @
s->writeLock();
plugin->outputScalars().insert((*it)._name, s);
}
+ s->setTagName(nt);
} else if (plugin->outputScalars()[(*it)._name]->tagName() != nt) {
while (KstData::self()->vectorTagNameNotUnique(nt, false)) {
nt += "'";
@ -558,6 +564,7 @
s->writeLock();
plugin->outputScalars().insert((*it)._name, s);
}
+ s->setTagName(nt);
}
}
}
More information about the Kst
mailing list