[Kst] extragear/graphics/kst/src

[Adam Treat]

On Friday 06 October 2006 7:55 pm, Adam Treat wrote:
> On Friday 06 October 2006 7:28 pm, George Staikos wrote:
> > On Friday 06 October 2006 19:14, Adam Treat wrote:
> > > SVN commit 593166 by treat:
> > >
> > > * This is related to the 593145.  I don't like the
> > > param for locking, but I see no way around it.
> > >
> > >
> > > -void KstEquation::setEquation(const QString& in_fn) {
> > > +void KstEquation::setEquation(const QString& in_fn, bool lockData) {
> >
> >   I think we need to make an effort to determine what the root of this is
> > and how we can avoid it.  For now it's fine.
>
> KstEquation::setEquation is called internally from other methods in
> KstEquation.
>
> KstEquation::setEquation is also called from KstEqDialogI where the
> equation object is locked previously.  Locking the equation object locks
> all the inputScalars associated with it and then setEquation unlocks all of
> them, clears them, reparses the equation, and adds the newly found
> equations scalars.  These scalars need to be relocked because
> KstEqDialogI::editSingleObject() will eventually unlock the equation object
> which necessarily unlocks all the _inputScalars.

What a mouthful ;)  Sorry.

Adam