[Kst] [Bug 135232] Crash on editing equation with non-existent vectors

Adam Treat treat at kde.org
Sat Oct 7 01:42:30 CEST 2006


------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.
         
http://bugs.kde.org/show_bug.cgi?id=135232         
treat kde org changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |RESOLVED
         Resolution|                            |FIXED



------- Additional Comments From treat kde org  2006-10-07 01:42 -------
SVN commit 593176 by treat:

* This bug was really another instance of the others...
I can't make the equation editor crash now.

BUG: 135232


 M  +4 -2      kstequation.cpp  


--- trunk/extragear/graphics/kst/src/libkstmath/kstequation.cpp #593175:593176
 @ -25,7 +25,6  @
 
 // include files for Qt
 #include <qstylesheet.h>
-#include <qdeepcopy.h>
 
 // include files for KDE
 #include <klocale.h>
 @ -268,6 +267,7  @
   // document loading with vector lazy-loading
   setDirty();
   _equation = in_fn;
+
   VectorsUsed.clear();
 
   KstScalarMap::Iterator it = _inputScalars.begin();
 @ -293,7 +293,9  @
       Equation::FoldVisitor vis(&ctx, &_pe);
       KstStringMap sm;
 
-      if (_pe->collectObjects(VectorsUsed, _inputScalars, sm)) {
+      KstScalarMap tmp = _inputScalars;
+      if (_pe->collectObjects(VectorsUsed, tmp, sm)) {
+        _inputScalars = tmp;
         if (lockData) {
           KstScalarMap::Iterator it = _inputScalars.begin();
           for (; it != _inputScalars.end(); ++it) {


More information about the Kst mailing list