In general looks good, and it restores the window creation into the psd generator where it belongs. Only thing I can see is that the function type should use an enum, not a magic number. -- George Staikos KDE Developer http://www.kde.org/ Staikos Computing Services Inc. http://www.staikos.net/