[Kst] extragear/graphics/kst/src/libkstapp

[Andrew Walker]

George, could you be more specific. In particular what are the side effects
besides "doc set dirty when it isn't". Could you also describe some of the
cases that it misses. Thanks,

Andrew

On March 21, 2006 3:27 pm, George Staikos wrote:
> SVN commit 521230 by staikos:
>
> I ran this patch through many tests here and they confirm that there are
> many side effects to this (doc set dirty when it isn't, for instance).  It
> also misses more cases than it catches.  I think this is a losing cause,
> but if it's to be fixed, it needs to be done differently.
> REOPEN: 123568
>
>
>  M  +1 -2      kst2dplot.cpp
>
>
> --- trunk/extragear/graphics/kst/src/libkstapp/kst2dplot.cpp #521229:521230
> @@ -4157,7 +4157,6 @@
>      kstdDebug() << "mouse release: do update" << endl;
>      setDirty();
>      static_cast<KstViewWidget*>(view)->paint();
> -    emit modified();
>    }
>  }
>
> @@ -5038,7 +5037,7 @@
>    if (handled) {
>      view->paint();
>      e->accept();
> -    emit modified();
> +    //emit modified();
>      return;
>    }
>
> _______________________________________________
> Kst mailing list
> Kst at kde.org
> https://mail.kde.org/mailman/listinfo/kst