[Kst] [Bug 123568] Plot dialog out of sync with plot

[Andrew Walker]

If you revert the bug fix then please make sure you re-open the bug report.

-----Original Message-----
From: George Staikos [mailto:staikos at kde.org]
Sent: Saturday, March 18, 2006 2:22 PM
To: kst at kde.org
Subject: [Kst] [Bug 123568] Plot dialog out of sync with plot


------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.
         
http://bugs.kde.org/show_bug.cgi?id=123568         




------- Additional Comments From staikos kde org  2006-03-18 23:22 -------
I will revert this change if I don't hear back about it.  Is there no 
interest?

On Tuesday 14 March 2006 15:15, George Staikos wrote:
> I'm worried about this change for many reasons:
>
> 1) modified() causes many things to happen.  For instance, it sets the
> document to modified, so that exit prompts for save.  This is not what we
> want in these cases based on my last discussions with Barth about this.
> 2) It causes a forced update -> performance issue, and also if we're
> paused, we get an update when we shouldn't
> 3) It only covers a few cases.  KstScript that modifies the plot will not
> result in updated dialogs this way, for example.
>
> On Tuesday 14 March 2006 13:38, Andrew Walker wrote:
> > SVN commit 518631 by arwalker:
> >
> > BUG:123568 Ensure that plot dialog is sync'ed with plot
> >
> >  M  +2 -1      kst2dplot.cpp
> >
> >
> > --- trunk/extragear/graphics/kst/src/libkstapp/kst2dplot.cpp
> > #518630:518631  @ -4174,6 +4174,7  @
> >      kstdDebug() << "mouse release: do update" << endl;
> >      setDirty();
> >      static_cast<KstViewWidget*>(view)->paint();
> > +    emit modified();
> >    }
> >  }
> >
> >  @ -5054,7 +5055,7  @
> >    if (handled) {
> >      view->paint();
> >      e->accept();
> > -    //emit modified();
> > +    emit modified();
> >      return;
> >    }
> >
> > _______________________________________________
> > Kst mailing list
> > Kst kde org
> > https://mail.kde.org/mailman/listinfo/kst
_______________________________________________
Kst mailing list
Kst at kde.org
https://mail.kde.org/mailman/listinfo/kst