[Kst] [Bug 129271] Plot Dialog -> Apply Settings to: This Window is buggy.

[Andrew Walker]

------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.
         
http://bugs.kde.org/show_bug.cgi?id=129271         
arwalker sumusltd com changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |RESOLVED
         Resolution|                            |FIXED



------- Additional Comments From arwalker sumusltd com  2006-06-20 19:35 -------
SVN commit 553314 by arwalker:

BUG:129271 Mark all modified plots as dirty and paint all the necessary windows. Also remove multiple repaints for the window containing the plot being explicitly edited.

 M  +13 -6     kstplotdialog_i.cpp  


--- trunk/extragear/graphics/kst/src/libkstapp/kstplotdialog_i.cpp #553313:553314
 @ -695,6 +695,7  @
         plotExtra->removeChild(KstViewObjectPtr(vl));
       }
     }
+    plotExtra->setDirty();
   }
 }
 
 @ -758,6 +759,7  @
     
     // reversed
     plotExtra->setYReversed(_yReversed->isChecked());
+    plotExtra->setDirty();
   }
 }
 
 @ -822,6 +824,7  @
     }
     
     plotExtra->setXReversed(_xReversed->isChecked());
+    plotExtra->setDirty();
   }
 }
 
 @ -893,6 +896,7  @
     } else {
       KstDebug::self()->log(i18n( "Internal error: No Y scale type checked in %1." ).arg(Select->currentText()), KstDebug::Error);
     }
+    plotExtra->setDirty();
   }
 }
 
 @ -923,22 +927,24  @
   applyPlotMarkers(plot);
 
   plot->setDirty();
-  static_cast<KstViewWindow*>(c)->view()->paint(KstPainter::P_PLOT);
 
   // make sure we paint all the necessary windows
   if (appearanceAll->isChecked() ||
       XAxisAll->isChecked() ||
       YAxisAll->isChecked() ||
-      rangeAll->isChecked()) {
+      rangeAll->isChecked() ||
+      markersAll->isChecked()) {
     KMdiIterator<KMdiChildView*> *it = KstApp::inst()->createIterator();
     while (it->currentItem()) {
-      KstViewWindow *c = dynamic_cast<KstViewWindow*>(it->currentItem());
-      if (c) {
-        c->view()->paint(KstPainter::P_PLOT);
+      KstViewWindow *win = dynamic_cast<KstViewWindow*>(it->currentItem());
+      if (win) {
+        win->view()->paint(KstPainter::P_PLOT);
       }
       it->next();
     }
     KstApp::inst()->deleteIterator(it);
+  } else {
+    static_cast<KstViewWindow*>(c)->view()->paint(KstPainter::P_PLOT);
   }
 
   _plotName = Name->text().stripWhiteSpace();
 @ -1472,7 +1478,8  @
     plotExtra->setLineStyleMarkers(_comboMarkerLineStyle->currentItem());
     plotExtra->setLineWidthMarkers(_spinBoxMarkerLineWidth->value());
     plotExtra->setColorMarkers(_colorMarker->color());
-    plotExtra->setDefaultColorMarker(_checkBoxDefaultMarkerColor->isChecked());  
+    plotExtra->setDefaultColorMarker(_checkBoxDefaultMarkerColor->isChecked());
+    plotExtra->setDirty();
   }
 }