[Kst] [Bug 120827] Command line option -f fails for some asciifiles

[George Staikos]

On Friday 27 January 2006 14:17, Ted Kisner wrote:
> Perhaps we could have the datasource keep it's current behaviour (return
> the fields at line 0), but with these changes:
>
> 1.  add another parameter to the fieldListFor function that specifies the
> starting line.
>
> 2.  if readField is called with a field that is not in the fieldList, do an
> additional call to fieldListFor with the current start frame to detect any
> changes in the field list.  If the field is still not valid, the return an
> error like normal.
>
> So this has the following benefits:
>
> 1.  small code changes.
>
> 2.  The available fields are only re-scanned if the requested field is
> invalid.  In situations with a constant number of columns, this never
> happens.
>
> What do you all think?  Should I make these changes?  Are there any
> consequences I've missed?

  Sounds ok, but don't forget we're frozen so make sure you post a patch for 
review first.

Thanks


-- 
George Staikos
KDE Developer				http://www.kde.org/
Staikos Computing Services Inc.		http://www.staikos.net/