[Kst] [Bug 118675] Bordered view object properties have no effect

[netterfield at astro.utoronto.ca]

------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.
         
http://bugs.kde.org/show_bug.cgi?id=118675         




------- Additional Comments From netterfield astro utoronto ca  2006-01-26 18:58 -------
I think we should remove the options from the default dialog.  If a view object supports the features, they should add them themselves.  These features will never have meaning for boxes, and pictures don't currently support these ideas (though they should).

The following diff removes the fields from the default dialog, and adds a FIXME to pictures for future reference.  There are no added strings.

Index: kstborderedviewobject.cpp
===================================================================
--- kstborderedviewobject.cpp   (revision 502591)
+++ kstborderedviewobject.cpp   (working copy)
 @ -191,16 +191,6  @
     map.insert(QString("_kst_widgetType"), QString("QSpinBox"));
     map.insert(QString("_kst_label"), i18n("Border width"));
     map.insert(QString("minValue"), 0);
-  } else if (propertyName == "padding") {
-    map.insert(QString("_kst_widgetType"), QString("QSpinBox"));
-    map.insert(QString("_kst_label"), i18n("Padding"));
-    map.insert(QString("minValue"), 0);
-    map.insert(QString("enabled"), false);
-  } else if (propertyName == "margin") {
-    map.insert(QString("_kst_widgetType"), QString("QSpinBox"));
-    map.insert(QString("_kst_label"), i18n("Margin"));
-    map.insert(QString("minValue"), 0);
-    map.insert(QString("enabled"), false);
   }
   return map;
 }
Index: kstviewpicture.cpp
===================================================================
--- kstviewpicture.cpp  (revision 502591)
+++ kstviewpicture.cpp  (working copy)
 @ -249,6 +249,16  @
     map.insert(QString("_kst_widgetType"), QString("QSpinBox"));
     map.insert(QString("_kst_label"), i18n("Refresh timer"));
   }
+  // FIXME: uncomment once these are supported.
+  /* else if (propertyName == "padding") {
+  map.insert(QString("_kst_widgetType"), QString("QSpinBox"));
+  map.insert(QString("_kst_label"), i18n("Padding"));
+  map.insert(QString("minValue"), 0);
+} else if (propertyName == "margin") {
+  map.insert(QString("_kst_widgetType"), QString("QSpinBox"));
+  map.insert(QString("_kst_label"), i18n("Margin"));
+  map.insert(QString("minValue"), 0);
+}*/
   return map;
 }