[Kst] Proposed fix for bug 117817 (Only the first parameter is shown in fit labels)

[George Staikos]

On Wednesday 25 January 2006 18:53, Barth Netterfield wrote:
> if we plugin->update(-1); before we plugin->createFitScalars();, then the
> outputVector["Parameters"] will be up to date, and the label will work.
>
> The down side is that we will get an extra update out of it.  I think it is
> worth it!

  This is a recipe for freeze/deadlock/crash...  That function is under an 
explicit assumption that it only gets called from the update thread.  What 
part of the update needs to happen?

> Index: kstfitdialog_i.cpp
> ===================================================================
> --- kstfitdialog_i.cpp  (revision 502364)
> +++ kstfitdialog_i.cpp  (working copy)
> @@ -154,12 +154,13 @@
>      arg(plugin->plugin()->data()._readableName);
>
>    if (plugin->outputVectors().contains("Parameters")) {
> +    plugin->update(-1);
>      plugin->createFitScalars();
>      int i = 0;
>      int length = (plugin->outputVectors())["Parameters"]->length();
>      QString strParamName;
>      for (strParamName = plugin->plugin()->parameterName(0);
> -        !strParamName.isEmpty() && i < length;
> +         !strParamName.isEmpty() && i < length;
>           strParamName = plugin->plugin()->parameterName(++i)) {
>        if (plugin->outputScalars().contains(strParamName)) {
>          KstScalarPtr scalar = plugin->outputScalars()[strParamName];
> _______________________________________________
> Kst mailing list
> Kst at kde.org
> https://mail.kde.org/mailman/listinfo/kst

-- 
George Staikos
KDE Developer				http://www.kde.org/
Staikos Computing Services Inc.		http://www.staikos.net/