[Kst] [Bug 119531] New: Ambiguities in getdata's char type

[D.V.Wiebe]

------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.
         
http://bugs.kde.org/show_bug.cgi?id=119531         
           Summary: Ambiguities in getdata's char type
           Product: kst
           Version: unspecified
          Platform: Compiled Sources
        OS/Version: Linux
            Status: UNCONFIRMED
          Severity: normal
          Priority: NOR
         Component: general
        AssignedTo: kst kde org
        ReportedBy: dwiebe physics utoronto ca


Version:           1.2.0_devel (using KDE KDE 3.4.2)
Installed from:    Compiled From Sources
Compiler:          gcc (GCC) 3.4.5 
OS:                Linux

There's an unsigned/signed ambiguity in getdata's implementation of the char ('c') type and I'm not sure which one is desired.

Comments in getdata.h and the ConvertType() function consider 'c' to refer to unsigned chars.  Comments preceeding GetData() and the Add/Scale/Multiply/Linterp/&c.-data() functions, as well as FillFileFrame(), indicate 'c' to be signed.

Which one should it be?