[Kst] Strange problem using the change data file tool

George Staikos staikos at kde.org
Thu Feb 23 17:34:34 CET 2006

On Thursday 23 February 2006 11:18, Brisset, Nicolas wrote:
> > The reason it wasn't done in the past was that we don't want
> > to hold onto a datasource that isn't being used.  It's
> > possible that a datasource instance takes up quite a bit of
> > memory.  Does this patch make it work any better for you?
> YES ! That's exactly what I was hoping for :-) Thanks !
> By the way, I don't think the problem you mention is so bad. It sounds
> reasonable to me to expect that once the user clicks the "Next" button
> on the first page, he has chosen the appropriate file and is really
> going to work with it. The only case where that assumption would be
> wrong is if he clicks "Cancel" before finishing the wizard.. The
> instance will be kept until he nexts purges unused data from the data
> manager.
> I think the benefit of not calling the constructor twice when using the
> wizard "normally" by far surpasses the cost of a few lost KB or even MB
> in some much less frequent occasions.

  Ok but we can't commit this.  In some cases some of the loaders will hit 
pathological memory-consumption cases.  The user will realize the mistake and 
close the file, but it won't be closed in Kst memory.  The solution could be 
to keep track of which files we opened in page1, and close all the ones we 
didn't end up using when Finished.

George Staikos
KDE Developer				http://www.kde.org/
Staikos Computing Services Inc.		http://www.staikos.net/

More information about the Kst mailing list