[Kst] extragear/graphics/kst/src

Stephan Binner binner at kde.org
Thu Feb 16 18:31:55 CET 2006


SVN commit 510266 by binner:

fix uninitialised values and undefined return compiler warnings


 M  +13 -3     extensions/js/kjsembed/builtins/qfile_imp.cpp  
 M  +1 -1      extensions/js/kjsembed/qtbindings/qcombobox_imp.cpp  
 M  +1 -1      extensions/js/kjsembed/qtbindings/qmenudata_imp.cpp  
 M  +3 -0      libkst/kstdatacollection.cpp  


--- trunk/extragear/graphics/kst/src/extensions/js/kjsembed/builtins/qfile_imp.cpp #510265:510266
@@ -389,7 +389,7 @@
 KJS::Value QFileImp::at_15( KJS::ExecState *exec, KJS::Object &obj, const KJS::List &args )
 {
 
-    QFile::Offset arg0; // TODO (hack for qfile)
+    QFile::Offset arg0 = 0; // TODO (hack for qfile)
 
       bool ret;
       ret = instance->at(
@@ -566,10 +566,20 @@
 
 }
 
+static QCString dummy_encoder( const QString &fileName )
+{
+    return fileName.local8Bit();
+}
+
+static QString dummy_decoder( const QCString &fileName )
+{
+    return QString(fileName);
+}
+
 KJS::Value QFileImp::setEncodingFunction_29( KJS::ExecState *exec, KJS::Object &obj, const KJS::List &args )
 {
 
-    QFile::EncoderFn arg0; // TODO (hack for qfile)
+    QFile::EncoderFn arg0 = dummy_encoder; // TODO (hack for qfile)
 
       instance->setEncodingFunction(
        arg0 );
@@ -580,7 +590,7 @@
 KJS::Value QFileImp::setDecodingFunction_30( KJS::ExecState *exec, KJS::Object &obj, const KJS::List &args )
 {
 
-    QFile::DecoderFn arg0; // TODO (hack for qfile)
+    QFile::DecoderFn arg0 = dummy_decoder; // TODO (hack for qfile)
 
       instance->setDecodingFunction(
        arg0 );
--- trunk/extragear/graphics/kst/src/extensions/js/kjsembed/qtbindings/qcombobox_imp.cpp #510265:510266
@@ -775,7 +775,7 @@
 KJS::Value QComboBoxImp::setInsertionPolicy_32( KJS::ExecState *exec, KJS::Object &obj, const KJS::List &args )
 {
 
-    QComboBox::Policy arg0; // TODO (hack for combo box)
+    QComboBox::Policy arg0 = QComboBox::AtBottom; // TODO (hack for combo box)
 
       instance->setInsertionPolicy(
        arg0 );
--- trunk/extragear/graphics/kst/src/extensions/js/kjsembed/qtbindings/qmenudata_imp.cpp #510265:510266
@@ -184,7 +184,7 @@
     QMenuData *ret = new QMenuData(
         );
 
-
+    return KJS::Object();
 }
 
 KJS::Value QMenuDataImp::call( KJS::ExecState *exec, KJS::Object &self, const KJS::List &args )
--- trunk/extragear/graphics/kst/src/libkst/kstdatacollection.cpp #510265:510266
@@ -211,16 +211,19 @@
 
 int KstData::vectorToFile(KstVectorPtr v, QFile *f) {
   // FIXME: implement me (non-gui)
+  return 0;
 }
 
 
 int KstData::vectorsToFile(const KstVectorList& l, QFile *f, bool interpolate) {
   // FIXME: implement me (non-gui)
+  return 0;
 }
 
 
 int KstData::columns(const QString& window) {
   Q_UNUSED(window)
+  return 0;
 }
 
 


More information about the Kst mailing list