[Kst] branches/work/kst/hierarchy/kst/src/libkstmath
George Staikos
staikos at kde.org
Mon Dec 4 17:09:33 CET 2006
How did you find this one? We should make some testcases for this.
On 1-Dec-06, at 8:56 PM, Eli Fidler wrote:
> SVN commit 609721 by fidler:
>
> fix uninitialized variables which caused a crash
>
>
> M +3 -0 kstbasecurve.cpp
> M +21 -11 kstbasecurve.h
>
>
> --- branches/work/kst/hierarchy/kst/src/libkstmath/kstbasecurve.cpp
> #609720:609721
> @@ -30,6 +30,9 @@
>
>
> void KstBaseCurve::commonConstructor() {
> + _ns_maxx = _ns_minx = _ns_maxy = _ns_miny = MaxX = MinX =
> MinPosX = MeanX = MaxY = MinY = MinPosY = 0.0;
> + NS = 0;
> +
> _ignoreAutoScale = false;
> _parsedLegendTag = 0L;
> }
> --- branches/work/kst/hierarchy/kst/src/libkstmath/kstbasecurve.h
> #609720:609721
> @@ -31,17 +31,27 @@
> */
>
> // context for rendering a curve in a plot
> -struct KstCurveRenderContext {
> - KstPainter* p;
> - double Lx, Hx, Ly, Hy;
> - double m_X, m_Y, b_X, b_Y;
> - double x_max, y_max, x_min, y_min;
> - double XMin, YMin, XMax, YMax; // range and domain of plot
> - bool xLog, yLog;
> - double xLogBase, yLogBase;
> - QColor foregroundColor; // plot foreground color
> - QColor backgroundColor; // plot background color
> - int penWidth;
> +class KstCurveRenderContext {
> + public:
> + // FIXME: use reasonable defaults
> + KstCurveRenderContext() : p(0L), Lx(0.0), Hx(0.0), Ly(0.0), Hy
> (0.0),
> + m_X(0.0), m_Y(0.0), b_X(0.0), b_Y(0.0),
> + x_max(0.0), y_max(0.0), x_min(0.0),
> y_min(0.0),
> + XMin(0.0), YMin(0.0), XMax(0.0), YMax
> (0.0),
> + xLog(false), yLog(false), xLogBase
> (0.0),
> + yLogBase(0.0), penWidth(0)
> + {}
> +
> + KstPainter* p;
> + double Lx, Hx, Ly, Hy;
> + double m_X, m_Y, b_X, b_Y;
> + double x_max, y_max, x_min, y_min;
> + double XMin, YMin, XMax, YMax; // range and domain of plot
> + bool xLog, yLog;
> + double xLogBase, yLogBase;
> + QColor foregroundColor; // plot foreground color
> + QColor backgroundColor; // plot background color
> + int penWidth;
> };
>
> enum KstCurveType { KST_VCURVE, KST_HISTOGRAM, KST_IMAGE };
> _______________________________________________
> Kst mailing list
> Kst at kde.org
> https://mail.kde.org/mailman/listinfo/kst
--
George Staikos
KDE Developer http://www.kde.org/
Staikos Computing Services Inc. http://www.staikos.net/
More information about the Kst
mailing list