[Kst] [Bug 131679] Invalid coordinates when moving end point of line

Duncan Hanson duncan.hanson at gmail.com
Wed Aug 2 01:15:27 CEST 2006


George- I think that when you changed the QMIN/QMAX to kMin/kMax in
KstTopLevelView::pressMoveLayoutModeEndPoint you changed npos to pos- so
that npos inside the bounds is not correctly ensured. Changing this back
will fix the assert crash when moving line endpoints.

dh.

On Tue, 2006-08-01 at 18:57 +0000, Duncan Hanson wrote:
> ------- You are receiving this mail because: -------
> You are the assignee for the bug, or are watching the assignee.
>          
> http://bugs.kde.org/show_bug.cgi?id=131679         
> 
> 
> 
> 
> ------- Additional Comments From duncan.hanson gmail com  2006-08-01 20:57 -------
> SVN commit 568625 by dhanson:
> 
> CCBUG:131679 fix assertion error when creating newLines. the problem when resizing lines does not occur in the viewaspect branch. something must have been backed out when merging, probably the patch for resize behaviour. currently, a 2 line change in KstTopLevelView::pressMoveLayoutModeEndPoint similar to the one commited is all that's necessary to fix the problem for moving lines, but i'll wait until we figure out what to do about the resizing behaviour before submitting it.
> 
>  M  +2 -1      kstgfxmousehandlerutils.cpp  
> 
> 
> --- trunk/extragear/graphics/kst/src/libkstapp/kstgfxmousehandlerutils.cpp #568624:568625
>  @ -186,7 +186,8  @
>  QRect KstGfxMouseHandlerUtils::newLine(const QPoint& pos, const QPoint& mouseOrigin, bool specialAspect, const QRect& bounds) {
>  
>    if (KDE_ISLIKELY(!specialAspect)) {
> -    return QRect(mouseOrigin,pos);
> +    QPoint npos = KstGfxMouseHandlerUtils::findNearestPtOnLine(mouseOrigin, pos, pos, bounds);
> +    return QRect(mouseOrigin, npos);
>    } else { //want special 45deg, or vertical, or horizontal line. 
>      QPoint npos;
>      QPoint mouseDisplacement(pos - mouseOrigin); // for picking type of line..
> _______________________________________________
> Kst mailing list
> Kst at kde.org
> https://mail.kde.org/mailman/listinfo/kst



More information about the Kst mailing list