[Kst] branches/work/kst/viewaspect/kst/src/libkstapp

Duncan Hanson duncan.hanson at gmail.com
Tue Aug 1 18:15:59 CEST 2006

On Tue, 2006-08-01 at 03:13 -0400, George Staikos wrote:
> On Wednesday 31 May 2006 20:34, Duncan Hanson wrote:
> > I've included a patch. I suppose the objection can be made that the
> > KstViewObject is drawing outside its bounds, but the bounds into which
> > it draws are dictated by a KstTopLevelView, so ultimate control is still
> > in the proper place.
>    Drawing outside the bounds violates the preconditions of the objects, so 
> this patch could not be committed.
> > > > Another example of KstTopLevel view knowing about specific
> > > > viewobjects is in KstTopLevelView::pressMoveLayoutModeEndPoint, when
> > > > the viewobject must be typecast to a KstViewLine. Why don't we move all
> > > > the resizing code into the view objects themselves.
> > >
> > >   Yes please, I was meaning to do this at some point!
> >
> > It will probably be best to work out this (and the painting) in a
> > separate branch. Can you create one from for me from the viewaspect
> > branch (or from the trunk if you end up merging)? Maybe call it the
> > resize branch.
>   Were you still planning to do this?  If you need to branch, just "svn cp" to 
> the same directory the viewaspect branch was in, giving it an appropriate 
> name.

If we can't give the ViewObjects special permission to paint outside
their bounds, then moving the resize code into them won't solve our
problem. We'll still have to have object specific resize painting done
at some higher level.

So I'm not still planning to do this.


More information about the Kst mailing list