[Kst] extragear/graphics/kst/kst
George Staikos
staikos at kde.org
Thu Sep 15 22:47:57 CEST 2005
SVN commit 460952 by staikos:
I'm not sure why this was done, but it seems to be wrong. There are many non-
editable vectors and matrices that will need to be purged too. Was it intended
to purge -all- editable vectors and matrices regardless of reference count? If
so, that's a different case altogether, but I'm not sure if that's wise since it
could leave to very confusing object hierarchies. For now, revert.
M +2 -3 kstdoc.cpp
--- trunk/extragear/graphics/kst/kst/kstdoc.cpp #460951:460952
@@ -874,8 +874,7 @@
// clear unused vectors that are editable
for (KstVectorList::Iterator it = vectorList.begin(); it != vectorList.end(); ++it) {
//kdDebug() << "VECTOR: " << (*it)->tagName() << " USAGE: " << (*it)->getUsage() << endl;
- // make sure it is used and it is editable (not a slave vector)
- if ((*it)->getUsage() == 1 && (*it)->editable()) {
+ if ((*it)->getUsage() == 1) {
//kdDebug() << " -> REMOVED" << endl;
KST::vectorList.lock().writeLock();
KST::vectorList.remove((*it).data());
@@ -889,7 +888,7 @@
// clear unused matrices that are editable
for (KstMatrixList::Iterator it = matrixList.begin(); it != matrixList.end(); ++it) {
- if ((*it)->getUsage() == 1 && (*it)->editable()) {
+ if ((*it)->getUsage() == 1) {
//kdDebug() << " -> REMOVED" << endl;
KST::matrixList.lock().writeLock();
KST::matrixList.remove((*it).data());
More information about the Kst
mailing list