[Kst] extragear/graphics/kst/kst

George Staikos staikos at kde.org
Mon Sep 12 18:25:15 CEST 2005


On Wednesday 17 August 2005 18:02, Andrew Walker wrote:
> SVN commit 450320 by arwalker:
>
> prevent crash resulting from invalid pointer
>
> --- trunk/extragear/graphics/kst/kst/labelrenderer.cpp #450319:450320
> @@ -30,6 +30,7 @@
>    int oldSize = rc.size;
>    int oldY = rc.y;
>    int oldX = rc.x;
> +
>    while (fi) {
>      if (fi->vOffset != Label::Chunk::None) {
>        if (fi->vOffset == Label::Chunk::Up) {
> @@ -47,12 +48,14 @@
>
>      if (fi->group) { // groups have no contents
>        fi = fi->next;
> +      continue;
>      }

  Do you have a testcase for this?  I'm not sure yet why there could be a 
group that is empty, but we definitely need to have testcases for these 
things.

-- 
George Staikos
KDE Developer				http://www.kde.org/
Staikos Computing Services Inc.		http://www.staikos.net/


More information about the Kst mailing list