[Kst] extragear/graphics/kst/kst
George Staikos
staikos at kde.org
Wed Oct 26 03:53:51 CEST 2005
SVN commit 474313 by staikos:
I just discovered this missing lock in kstvector. This is a serious potential
for crash. It affects 1.1.1 as well, but it needs testing first. Should we
hold 1.1.1 or release 1.1.1 and do a very quick 1.1.2 with this fix and some
performance work?
I'll backport after testing is complete.
M +2 -0 kstvector.cpp
--- trunk/extragear/graphics/kst/kst/kstvector.cpp #474312:474313
@@ -297,7 +297,9 @@
if (update_counter > 0) {
KstObjectPtr prov = KstObjectPtr(_provider);
if (prov) {
+ prov->writeLock();
providerRC = prov->update(update_counter);
+ prov->writeUnlock();
if (!force && providerRC == KstObject::NO_CHANGE) {
return setLastUpdateResult(providerRC);
}
More information about the Kst
mailing list