[Kst] extragear/graphics/kst/kst

[George Staikos]

On Saturday 22 October 2005 13:34, Barth Netterfield wrote:
>  // FIXME: broken copy constructor
> +// what is broken?

   It doesn't behave like a proper copy constructor.  Very confusing from a 
C++ perspective.  I'll clean all that up once we get to proper DnD and 
undo/redo.
   
> -  // FIXME: make more efficient

   This isn't fixed yet.  We reparse and render numbers that we don't need to.  
We should cache it.

>    // FIXME: dirty for xlabel, ylabel, toplabel
> +  // don't know what there is to fix... plotlabels no longer cache (and
> don't need to). //dirty = dirty || XLabel->dirty() || YLabel->dirty() ||
> TopLabel->dirty(); #if 0
>    XLabel->setDirty(false);
> @@ -2395,7 +2397,6 @@
>    }

   Quite possibly.  I just marked it because I broke it before.

> +        p.save();
> +        p.translate(d2i(xTickPos), yTickPos);
> +        _xTickLabel->paint(p);
> +        p.restore();
>          // FIXME XTickLabel->draw(p, d2i(xTickPos + (0.5 *
> XTickLabel->rotatedWidth(p))), d2i(y_px - ybot_bdr_px +
> 0.4*XTickLabel->rotatedHeight(p))); } else if (_xTickLabel->rotation() < 0)

  I guess we can axe these FIXMEs now?

-- 
George Staikos
KDE Developer				http://www.kde.org/
Staikos Computing Services Inc.		http://www.staikos.net/