[Kst] [Bug 111571] dirfile data source poorly handles errorconditions.

[George Staikos]

On Tuesday 11 October 2005 18:13, Andrew Walker wrote:
> I'm not sure that changing exit to abort really addresses this bug. As I
> read it
> the point was to ensure that the data source doesn't simply die as the
> result of
> some format error, which could be very annoying for the user. At worst the
> data
> source should simply return an error code or refuse to read any data. At
> best
> the user would receive some meaningful error message that would allow them
> to
> correct the problem.

   Which case gets this from disk as opposed to from code?  If it's a bug in 
code, abort() is fine.  If it's from disk or user input, then you're right, 
abort() is the wrong choice.  I didn't see a path to get return_type from 
disk, and the comments all said "impossible happened" or similar.

-- 
George Staikos
KDE Developer				http://www.kde.org/
Staikos Computing Services Inc.		http://www.staikos.net/