[Kst] extragear/graphics/kst/kst

George Staikos staikos at kde.org
Wed Nov 23 01:16:02 CET 2005


On Tuesday 22 November 2005 19:05, Matthew D Truch wrote:
> On Tue, Nov 22, 2005 at 11:37:26PM +0000, George Staikos wrote:
> > SVN commit 482453 by staikos:
> > --- trunk/extragear/graphics/kst/kst/kstviewobject.cpp #482452:482453
> > @@ -674,10 +673,7 @@
> >      }
> >
> >      for (KstViewObjectList::Iterator it = childrenCopy.begin(); it !=
> > childrenCopy.end(); ++it) { -      distance  = ceil( (double)rows * 2.0 *
> > (*it)->aspectRatio().y ); -      distance  = rows * d2i( distance );
> > -      distance += (*it)->aspectRatio().x * rows;
> > -      distance += (*it)->aspectRatio().y;
> > +      double distance = ceil(double(rows) * 2.0 *
> > (*it)->aspectRatio().y) + rows * d2i(distance) + (*it)->aspectRatio().x *
> > rows + (*it)->aspectRatio().y;
> >
> >        if (it == childrenCopy.begin() || distance < minDistance) {
> >          minDistance = distance;
>
> I don't understand this commit.  Since the second deleted line didn't
> have a += but actually had an =, isn't distance (the argument to d2i)
> undefined in the line you added?  Am I missing some kind of voodoo
> recursive definition thing here?

  Argh, did undo too far, will fix shortly.

-- 
George Staikos
KDE Developer				http://www.kde.org/
Staikos Computing Services Inc.		http://www.staikos.net/


More information about the Kst mailing list