[Kst] extragear/graphics/kst/kst

George Staikos staikos at kde.org
Tue Nov 1 23:14:01 CET 2005

On Tuesday 01 November 2005 16:45, Ted Kisner wrote:
> SVN commit 476732 by tskisner:
> When loading an image from a kst file, it will crash unless we actually
> load the matrix into _inputMatrices when parsing the Dom.  This fixes the
> problems I was having when saving a healpix image (or simply trying to
> save/load the example asciimatrix.txt image)
>    _inputMatrixLoadQueue.append(qMakePair(THEMATRIX, in_matrixName));
> +  KstDataObject::loadInputs();

  Maybe I'm misunderstanding, but I think this will cause crashes or 
inconsistencies too.  loadInputs() is supposed to be called only after all 
the objects are constructed because the kst file may be out-of-order.  I 
think this patch is wrong and somewhat defeats the whole purpose of 
loadInputs().  Maybe there is another approach?

George Staikos
KDE Developer				http://www.kde.org/
Staikos Computing Services Inc.		http://www.staikos.net/

More information about the Kst mailing list