[Kst] extragear/graphics/kst/kst

[George Staikos]

On Tuesday 24 May 2005 13:19, Rick Chern wrote:
> On Fri, 2005-05-20 at 20:00 -0400, George Staikos wrote:
> > Also it's quite a huge change.  Some parts of it don't even seem to be
> > related to the commit log.  Can you provide some more insight into the
> > changes and your approach?
>
> Can you clarify what you mean in that some parts are not related to the
> commit log (were there changes that did not relate to the "multiple
> edit" mode that were committed)?

   Here is one of them.  I haven't fully reviewed the commit yet, but I saw 
this one quickly and I really didn't see how it was related.  With huge 
commits/changes like this, it's really nice to send a note to the message or 
bug report with what the changes are that you will be making and perhaps 
detailing the approach.

Thanks

------------------------------------------------------------------------
Index: kstimage.cpp
===================================================================
--- kstimage.cpp        (revision 417847)
+++ kstimage.cpp        (revision 417848)
@@ -292,7 +292,8 @@
   _zLower = lowerZ;
   _zUpper = upperZ;
   _autoThreshold = autoThreshold;
-  delete _pal;
+  if (_pal != pal)
+    delete _pal;
   _pal = pal;
   _hasColorMap = true;
   _hasContourMap = false;
@@ -324,7 +325,8 @@
   _zLower = lowerZ;
   _zUpper = upperZ;
   _autoThreshold = autoThreshold;
-  delete _pal;
+  if (_pal != pal)
+    delete _pal;
   _pal = pal;
   _numContourLines = numContours;
   _contourWeight = contourWeight;

-- 
George Staikos
KDE Developer				http://www.kde.org/
Staikos Computing Services Inc.		http://www.staikos.net/