[Kst] kdeextragear-2/kst/kst

[Barth Netterfield]

Can we stop talking about this now?

cbn

On March 16, 2005 11:43 am, George Staikos wrote:
> On Wednesday 16 March 2005 11:28, Andrew Walker wrote:
> > Not sure if the previous email I sent made it hrough, so here it is
> > again. How to repduce this problem:
> >
> > If you have the main.cpp version before my latest change then
> > do something like:
> >
> > kst gyrodata.dat -y 1 -m 99999999999
> >
> > If you have my latest changes to main.cpp then do the following:
> >
> > ksy gyrodata.dat -y 1 -m 10
>
>    Neither of those crash or assert for me.
>
> > then simply start shrinking the window down in the horizontal
> > direction, until you get a crash or assert.
> >
> > As the code was previously the result would crash in both
> > deubg and release. As it was (with George's assert) it would assert
> > in debug and crash in release. The problem was not caught
> > and we have now released a version with this bug - when some
> > simple defensive programming would have prevented it.
>
>    These are also uncommon use cases, and well, I can find endless ways to
> crash Kst and endless ways to add if() everywhere, and then endless more
> ways to crash it.  We could easily double the amount of code in Kst adding
> protection for that 0.01% of the usage cases.  The code will be a nightmare
> to work with and our productivity will fall.  Furthermore, the design of
> the code will be wrong to begin with, so we'll be adding if() until the
> cows come home.  Let's fix the real bugs instead of making a mess of
> things.