[Kst] kdeextragear-2/kst/kst

George Staikos staikos at kde.org
Thu Mar 3 00:52:15 CET 2005


CVS commit by staikos: 

no longer true due to previous fixes


  M +1 -1      kstvectordialog_i.cpp   1.63
  M +3 -3      main.cpp   1.99


--- kdeextragear-2/kst/kst/kstvectordialog_i.cpp  #1.62:1.63
@@ -95,5 +95,5 @@ void KstVectorDialogI::updateCompletion(
   KST::dataSourceList.lock().readUnlock();
 
-  delete _configWidget; // FIXME: very inefficient!!!!
+  delete _configWidget;
   _configWidget = 0L;
   QStringList list;

--- kdeextragear-2/kst/kst/main.cpp  #1.98:1.99
@@ -101,5 +101,5 @@ static void CheckForCMDErrors(KCmdLineAr
   if (args->getOption("n").toInt(&nOK) == 0) {
     kdError() << i18n("Exiting because '-n 0' requests vectors with no data in them.") << endl;
-    exit(0); // FIXME: can cause crashes
+    exit(0); // ugly but now safe
   }
   if (args->getOption("n").toInt(&nOK)>0) {
@@ -107,5 +107,5 @@ static void CheckForCMDErrors(KCmdLineAr
         2*args->getOption("s").toInt(&nOK)) {
       kdError() << i18n("Requested data skipping would leave vector with fewer than two points.") << endl;
-      exit(0); // FIXME: can cause crashes
+      exit(0); // ugly but now safe
     }
   }
@@ -254,5 +254,5 @@ static KstRVector *GetOrCreateVector(con
   if (!V->isValid()) {
     kdError() << i18n("Invalid field: %1 in file %2").arg(V->field()).arg(V->filename()) << endl;
-    exit(0); // FIXME: this can cause crashes
+    exit(0); // ugly but now safe
   }
 




More information about the Kst mailing list