[Kst] [Bug 108025] Matrix and image reworking

[George Staikos]

------- You are receiving this mail because: -------
You are on the CC list for the bug, or are watching someone who is.
         
http://bugs.kde.org/show_bug.cgi?id=108025         




------- Additional Comments From staikos kde org  2005-07-25 20:43 -------
On Monday 25 July 2005 13:54, Rick Chern wrote:
> 19:54 ------- I am waiting for the changes mentioned previously:
> After matrices are renovated, KstImage needs to be converted into a
> KstBaseCurve and adjusted somewhat to be a generic curve with a matrix
> for storing data.  It is desired at some point to be able to render all
> sort of different image formats easily with this class.  This change,
> however, depends on changes to Kst2DPlot to an extent, and should wait
> for those changes.  (they are minor)
>
> For now, should KstImage just be changed into a subclass of KstBaseCurve
> (and most of the plotting code would stay the same)?


   I actually did that (KstImage into a BaseCurve) once before but it was too 
close to the release so I had to junk it.  It's quite diverged now, so the 
patch is useless.  It did seem to work, though, so I think it's the right 
approach.  If you want you can pull out the Kst2DPlot code too.  The first 
step should look roughly like this:

  1) BaseCurve properties that really belong in VCurve get demoted.
  2) KstCurveRenderContext is created which contains the long list of 
parameters (and the painter) that a curve needs in order to draw itself into 
that painter.
  3) BaseCurve gets a paint()/draw()/whatever virtual function that takes this 
context and the painting code moves from Kst2DPlot to the curves.
  4) KstImage becomes a KstBaseCurve

  I'll take care of updating the script bindings as the changes happen.  Once 
this is done, I should be able to bind matrices and images completely.

  Is there anything else you know of that we should deal with while we're 
fixing it?  The label code is also a big issue, but it's fairly separate.