[Kst] [Bug 108933] Potential threading problem should be investigated

[Rick Chern]

------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.
         
http://bugs.kde.org/show_bug.cgi?id=108933         
rchern interchange ubc ca changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |RESOLVED
         Resolution|                            |FIXED



------- Additional Comments From rchern interchange ubc ca  2005-07-12 19:01 -------
SVN commit 434028 by rchern:

- use KST::matrixList instead of old matrix dataobject in some other places
- write unlock after write locking

CCMAIL: 108933-done bugs kde org

 M  +1 -0      kstdataobject.cpp  
 M  +1 -1      kstmatrixdialog_i.cpp  
 M  +1 -1      kstmatrixtable.cpp  
 M  +1 -1      kstviewmatricesdialog_i.cpp  


--- trunk/extragear/graphics/kst/kst/kstdataobject.cpp #434027:434028
 @ -75,6 +75,7  @
        ++it) {
     KST::matrixList.remove(it.data());       
   }
+  KST::matrixList.lock().writeUnlock();
   //kdDebug() << "+++ DESTROYING DATA OBJECT: " << (void*)this << endl;
   delete _curveHints;
 }
--- trunk/extragear/graphics/kst/kst/kstmatrixdialog_i.cpp #434027:434028
 @ -608,7 +608,7  @
 
 
 bool KstMatrixDialogI::edit_I() {
-  KstMatrixList mxList = kstObjectSubList<KstDataObject,KstMatrix>(KST::dataObjectList);
+  KstMatrixList mxList = KST::matrixList;
 
   // if editing multiple objects, edit each one
   if (_editMultipleMode) {    
--- trunk/extragear/graphics/kst/kst/kstmatrixtable.cpp #434027:434028
 @ -32,7 +32,7  @
 }
 
 void KstMatrixTable::paintCell( QPainter* painter, int row, int col, const QRect& cr, bool selected, const QColorGroup& cg ) {
-  KstMatrixList matrices = kstObjectSubList<KstDataObject, KstMatrix>(KST::dataObjectList);
+  KstMatrixList matrices = KST::matrixList;
   KstMatrixPtr matrix = *matrices.findTag(_strMatrix);
   QString str;
   double value;
--- trunk/extragear/graphics/kst/kst/kstviewmatricesdialog_i.cpp #434027:434028
 @ -64,7 +64,7  @
 void KstViewMatricesDialogI::updateViewMatricesDialog(const QString& matrixName) {
   int needed = 0;
   
-  KstMatrixList matrices = kstObjectSubList<KstDataObject, KstMatrix>(KST::dataObjectList);
+  KstMatrixList matrices = KST::matrixList;
   KstMatrixPtr matrix = *matrices.findTag(matrixName);
   if (matrix) {
     matrix->readLock();