[Kst] Skip

George Staikos staikos at kde.org
Mon Jan 24 03:56:31 CET 2005


  I have this [still under development] patch to kstrvector which I think 
fixes many little bugs in skip.  Presently skip does some things that I 
consider strange.  Behavior on a vector [0,1,2,...,11,12] does this for given 
skip values:

skip=2
2,4,6,8,10
skip=3
3,6,9
skip=4
4,8
skip=5
5
skip=6
6
skip=7
7
skip=8
8

I think the vectors should look like this, and my patch behaves accordingly:
skip=2
1,3,5,7,9,11
skip=3
2,5,8,11
skip=4
3,7,11
skip=5
4,9
skip=6
5,11
skip=7
6
skip=8
7

There is some numerical fudging in my patch also, but it only breaks down in 
the case where skip=1 (I think).  I think doing skip where skip=1 is silly 
anyway, and so my patch disables skip when it's set to 1 (or less, as a 
sanity check).

Any comments?  I haven't tested this code with anything other than my "0..12" 
vector, and I haven't tested it with samplesPerFrame > 1.  I guess it needs 
testing with various dirfiles.

-- 
George Staikos
KDE Developer				http://www.kde.org/
Staikos Computing Services Inc.		http://www.staikos.net/
-------------- next part --------------
A non-text attachment was scrubbed...
Name: skipfixes.patch
Type: text/x-diff
Size: 2335 bytes
Desc: not available
Url : http://mail.kde.org/pipermail/kst/attachments/20050123/1e3fedea/skipfixes.bin


More information about the Kst mailing list