[Kst] [Bug 118608] Pulse Extension doesn't remove menu entry when unloaded

George Staikos staikos at kde.org
Mon Dec 19 04:25:46 CET 2005


------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.
         
http://bugs.kde.org/show_bug.cgi?id=118608         
staikos kde org changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|UNCONFIRMED                 |RESOLVED
         Resolution|                            |FIXED



------- Additional Comments From staikos kde org  2005-12-19 04:25 -------
SVN commit 489553 by staikos:

properly unload extensions, since the crash is now fixed
BUG: 118608


 M  +4 -2      js/js.cpp  
 M  +4 -0      pulse/pulse.cpp  


--- trunk/extragear/graphics/kst/kst/extensions/js/js.cpp #489552:489553
 @ -138,8 +138,10  @
   delete _iface;
   _iface = 0L;
   destroyRegistry();
-  // crash
-  //app()->guiFactory()->removeClient(this);
+  KstApp *app = this->app();
+  if (app && app->guiFactory()) {
+    app->guiFactory()->removeClient(this);
+  }
 }
 
 
--- trunk/extragear/graphics/kst/kst/extensions/pulse/pulse.cpp #489552:489553
 @ -51,6 +51,10  @
   for (KstGVectorList::Iterator i = gvl.begin(); i != gvl.end(); ++i) {
     (*i)->setFrequency(0);
   }
+  KstApp *app = this->app();
+  if (app && app->guiFactory()) {
+    app->guiFactory()->removeClient(this);
+  }
 }


More information about the Kst mailing list