[Kst] extragear/graphics/kst/kst

[Andrew Walker]

Are we supposed to draw borders if the label is transparent?

On December 16, 2005 3:42 pm, George Staikos wrote:
> On Friday 16 December 2005 18:33, Andrew Walker wrote:
> > SVN commit 489051 by arwalker:
> >
> > CCBUG:118148 Fix problem with transparency not being honoured when
> > printing p.save();
> > -  if (p.type() == KstPainter::P_PRINT) {
> > +  if (p.type() == KstPainter::P_PRINT ||
> > +      p.type() == KstPainter::P_EXPORT) {
> >      //p.save();
> >      if (_autoResize) {
> >        adjustSizeForText(p.window());
> > @@ -369,7 +369,9 @@
> >      }
> >    }
> >    p.restore();
> > -  KstBorderedViewObject::paint(p, bounds);
> > +  if (!_transparent) {
> > +    KstBorderedViewObject::paint(p, bounds);
> > +  }
> >  }
>
>   This second change looks wrong.  It will miss borders, for instance.  The
> real bug appears to be in KstBorderedViewObject if this change has any
> impact.