[Kst] kdeextragear-2/kst/kst/datasources/ascii

[George Staikos]

On Monday 04 April 2005 23:36, George Staikos wrote:
> On Monday 04 April 2005 23:20, Matthew D Truch wrote:
> > > --- kdeextragear-2/kst/kst/datasources/ascii/ascii.cpp  #1.37:1.38
> > > @@ -261,5 +261,5 @@ bool AsciiSource::isValidField(const QSt
> > >    field.toUInt(&ok);
> > >
> > > -  return ok;
> > > +  return ok && fieldList().contains(field);
> > >  }
> >
> > Doesn't && short-circuit left to right, so the
> > fieldList().contains(field) will never be executed, or does return
> > 'return' false?

  One more thing:  This is one of the great things about the regression suite:  
It detects bugs like this, and we know what to fix and how to fix it quite 
quickly!  This bug was found while fixing up the regression suite to match 
recent changes in Kst.

-- 
George Staikos
KDE Developer				http://www.kde.org/
Staikos Computing Services Inc.		http://www.staikos.net/