[Kst] [PATCH] another parser bug

George Staikos staikos at kde.org
Mon Nov 22 17:32:39 CET 2004


I found a bug in logical AND and OR parsing in the equation parser.  The 
following testcase failed:

Test of (1||2&&0)[0.0000000000000000] == 1.0000000000000000 failed.

It was being evaluated as (1||2) && 0 instead of 1 || (2&&0).  Attached patch 
fixes it.

I have test coverage of enodes.cpp up to 48.22% now, eparse.y is at 75.34%, 
and escan.l is at 33.93%.  A big chunk of the enodes.cpp coverage that is 
missing is plugin related, and I don't think I'll be automating testing of 
that today.

-- 
George Staikos
KDE Developer				http://www.kde.org/
Staikos Computing Services Inc.		http://www.staikos.net/
-------------- next part --------------
A non-text attachment was scrubbed...
Name: eparserfixes.patch
Type: text/x-diff
Size: 1096 bytes
Desc: not available
Url : http://mail.kde.org/pipermail/kst/attachments/20041122/90aa8d1b/eparserfixes.bin


More information about the Kst mailing list