Fwd: [Kst] [PATCH] thread exit

[Barth Netterfield]

OK.  Go ahead.

cbn

On November 17, 2004 06:38 pm, George Staikos wrote:
> On Wednesday 17 November 2004 18:46, Barth Netterfield wrote:
> > What are the implications?
> >
> > > I highly recommend this patch for 1.0.  An occasional crash or Qt
> > > message is better than a big pile of stale background processes using
> > > huge amounts of ram.
> > >
> > > On Friday 12 November 2004 10:41, George Staikos wrote:
> > > > CVS commit by staikos:
> > > >
> > > > seems to be the best solution for this broken environment
> > > >
> > > >
> > > >   M +1 -1      kst.cpp   1.256.2.2
> > > >
> > > >
> > > > --- kdeextragear-2/kst/kst/kst.cpp  #1.256.2.1:1.256.2.2
> > > > @@ -228,5 +228,5 @@ KstApp::~KstApp() {
> > > >      _updateThread->terminate();
> > > >  #endif
> > > > -    _updateThread->wait();
> > > > +    _updateThread->wait(3000); // QThread object destroyed while
> > > > thread running on RH 9, but freezes on exit without it. 
> > > > ->terminate() crashes. Can we win? #if 0
> > > >    }
>
>    We just kill the object and exit explicitly, and we no longer crash due
> to the atexit handler, hopefully.  I have a possible better fix but I doubt
> it will be in time for 1.0.