[Kst] kdeextragear-2/kst/kst

George Staikos staikos at kde.org
Mon Jun 28 03:48:19 CEST 2004


CVS commit by staikos: 

mark this stuff as deprecated, explain why


  M +16 -2     kstviewobject.h   1.54


--- kdeextragear-2/kst/kst/kstviewobject.h  #1.53:1.54
@@ -27,4 +27,7 @@
 #include <qsize.h>
 
+#include <kdemacros.h>
+#include <kdeversion.h>
+
 #include "kstobject.h"
 #include "kstalignment.h"
@@ -64,5 +67,11 @@ class KstViewObject : public KstObject {
     virtual ~KstViewObject();
 
-    KstViewWidget* viewWidget();
+    // Use of this method indicates a bug since an object may have 0, 1 or more
+    // views, which may or may not be widgets.
+    KstViewWidget* viewWidget()
+#if KDE_VERSION >= KDE_MAKE_VERSION(3,2,0)
+KDE_DEPRECATED
+#endif
+;
 
     virtual UpdateType update(int = -1);
@@ -205,5 +214,10 @@ class KstViewObject : public KstObject {
     bool _bZoomed : 1;
     int _columns : 6; // "64 columns ought to be enough for anyone"
-    KstViewObjectPtr _parent;
+    KstViewObjectPtr _parent; // FIXME: this is bad and should be removed ASAP
+                              //        It was introduced as a temporary hack
+                              //        but is no longer needed as events now
+                              //        pass the view pointer along.  Also use
+                              //        of this member indicates a bug since
+                              //        objects can have multiple parents.
     Q_UINT32 _standardActions, _layoutActions;
     KstAspectRatio _aspect;





More information about the Kst mailing list