[Kst] kdeextragear-2/kst/kst

George Staikos staikos at kde.org
Mon Jun 28 03:25:29 CEST 2004


On June 25, 2004 19:36, Andrew Walker wrote:
> CVS commit by arwalker:
>
> Make Zoom menu items functional.
>
> Improve consistency between menu items and corresponding dialog names.
>
>
>   M +11 -11    kst.cpp   1.165
>   M +354 -198  kst2dplot.cpp   1.110
>   M +3 -0      kst2dplot.h   1.41
>   M +20 -0     kstviewobject.cpp   1.70
>   M +5 -3      kstviewobject.h   1.52

  Why did you duplicate so much code that I had nicely factored?  It makes it 
very tedious to fix this code now.  Many of those functions are identical in 
almost all respects so there's no need to write them out.  Also I had put a 
lot of effort into trying to eliminate the temporary hack of having the 
_parent member, and this removes all of that work.  That's why the view point 
is supposed to come through as part of the event - they don't have any 
association to an actual widget, which would allow for many features in the 
future such as (for example) displaying output in multiple windows, or in a 
non-widget.

-- 
George Staikos
KDE Developer			http://www.kde.org/
Staikos Computing Services Inc.	http://www.staikos.net/



More information about the Kst mailing list