[Kst] kdeextragear-2/kst/kst

George Staikos staikos at kde.org
Thu Jul 15 23:37:30 CEST 2004


CVS commit by staikos: 

the last of the circular references - top level views verifiably disappear now,
but the bug report is still not fixed


  M +1 -1      ksttoplevelview.cpp   1.63
  M +0 -2      kstviewwindow.cpp   1.28


--- kdeextragear-2/kst/kst/ksttoplevelview.cpp  #1.62:1.63
@@ -59,5 +59,4 @@ void KstTopLevelView::commonConstructor(
 
 KstTopLevelView::~KstTopLevelView() {
-  kdDebug() << " Destroy toplevel view" <<  endl;
 }
 
@@ -835,4 +834,5 @@ void KstTopLevelView::cleanupAction() {
 
 void KstTopLevelView::release() {
+  clearChildren(); // FIXME: remove this once we get rid of _parent
   if (_w) {
     _w->release();

--- kdeextragear-2/kst/kst/kstviewwindow.cpp  #1.27:1.28
@@ -126,7 +126,5 @@ void KstViewWindow::updateActions() {
 KstViewWindow::~KstViewWindow() {
   KstApp::inst()->updateDialogsForWindow();
-  kdDebug() << "View window deleted - usage is at " << _view->_KShared_count() << endl;
   _view->release(); // bye bye - remove circular dependency and disappear
-  kdDebug() << "View released - usage is at " << _view->_KShared_count() << endl;
 }
 





More information about the Kst mailing list