[Kst] kdeextragear-2/kst

George Staikos staikos at kde.org
Sat Jul 10 00:06:20 CEST 2004


CVS commit by staikos: 

update data objects only when input vectors have changed.

note: we need to rethink updates yet again


  M +1 -1      devel-docs/RELEASE_PLAN-0.98   1.31
  M +4 -0      kst/updatethread.cpp   1.23


--- kdeextragear-2/kst/devel-docs/RELEASE_PLAN-0.98  #1.30:1.31
@@ -7,5 +7,4 @@
 - do events work?
 - "overwrite all" doesn't work in plugin manager <-- KIO related?
-- updates are calling plugins too often without need <-- major problem (George)
 - using QWaitCondition in update thread is bad - it's broken in all but the
   most recent Qt releases
@@ -13,4 +12,5 @@
 - locking is missing in places - especially dialogs (plugin, etc)
 - impossible to create data objects without plotting now
+- usage counts are all wrong
 
 

--- kdeextragear-2/kst/kst/updatethread.cpp  #1.22:1.23
@@ -199,4 +199,8 @@ bool UpdateThread::doUpdates(bool force,
   }
 
+  if (U == KstObject::NO_CHANGE) { // no need to update further
+    return false;
+  }
+
   {
     // Must make a copy to avoid deadlock





More information about the Kst mailing list