[Kst] kdeextragear-2/kst/kst

[George Staikos]

On Friday 09 July 2004 12:07, Barth Netterfield wrote:
> CVS commit by netterfield:
>
> Real time updating was not working, because the paint events were not
> actually being processed before giving the 'all clear' to the ui thread. 
> This fixes that, and improves on the clarity of the comments in the update
> thread.
>
>
> --- kdeextragear-2/kst/kst/kstdoc.cpp  #1.96:1.97
> @@ -797,5 +797,6 @@ bool KstDoc::event(QEvent *e) {
>      } else if (te->_eventType == ThreadEvent::Done) {
>      }
> -    _updating = false; // ok, we're done...
> +    kapp->processEvents(); // actually do the paints and check for inputs
> +    _updating = false; // ok, we're done... update thread can send us a
> new event.

   This patch really scares me.  It's part of what the whole multithreading 
design was supposed to eliminate - re-entering the event loop.  We had loads 
of weird crash cases in the old single-threaded code because of these calls.

-- 
George Staikos
KDE Developer				http://www.kde.org/
Staikos Computing Services Inc.		http://www.staikos.net/