[Kst] kdeextragear-2/kst/kst

[Andrew Walker]

I'm not sure I remember this was a bug. I put
in the _highlighting as if we needed to redraw
the data marker we would first ask for a repaint
and then draw the marker. During the repaint
we would check to see if we should draw the marker.
There was the potential for an infinite loop, hence
the _highlighting flag to avoid it. Drawing the
data marker no longer triggers a repaint, hence
no flag is necessary.

-----Original Message-----
From: George Staikos [mailto:staikos at kde.org]
Sent: Tuesday, December 28, 2004 9:11 PM
To: kst at kde.org
Cc: Andrew Walker
Subject: Re: [Kst] kdeextragear-2/kst/kst


On Thursday 23 December 2004 18:31, George Staikos wrote:
> On Wednesday 22 December 2004 21:17, Andrew Walker wrote:
> > CVS commit by arwalker:
> >
> > Remove obsolete checks in datamode.
> > -  _highlighting = false;
>
>    Why is this not needed anymore?  This was  avery nasty bug and I'd hate
> to see it reappear.  Did you somehow fix it so that it can't happen again?
> (Just curious because I'm in the middle of testing and preparing the devel
> release and I need to know if this change should stay in..)

   Andrew?  I need to know before I upload packages to the ftp server.

Thanks

-- 
George Staikos
KDE Developer				http://www.kde.org/
Staikos Computing Services Inc.		http://www.staikos.net/