[Kst] [Bug 95591] Changing data files with the change file dialog does not work.

[George Staikos]

------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.
        
http://bugs.kde.org/show_bug.cgi?id=95591        
staikos kde org changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |RESOLVED
         Resolution|                            |FIXED



------- Additional Comments From staikos kde org  2004-12-21 19:36 -------
CVS commit by staikos: 

fix reentrancy deadlock in almost all uses of this dialog
BUG: 95591


  M +2 -1      kstchangefiledialog_i.cpp   1.29


--- kdeextragear-2/kst/kst/kstchangefiledialog_i.cpp  #1.28:1.29
 @ -97,5 +97,5  @ void KstChangeFileDialogI::showChangeFil
 void KstChangeFileDialogI::applyFileChange() {
   KstDataSourcePtr file;
-  KstWriteLocker ml(&KST::dataSourceList.lock());
+  KST::dataSourceList.lock().writeLock();
   KstDataSourceList::Iterator it = KST::dataSourceList.findFileName(_dataFile->url());
   QString invalidSources;
 @ -164,4 +164,5  @ void KstChangeFileDialogI::applyFileChan
   file->writeUnlock();
   file = 0L;
+  KST::dataSourceList.lock().writeUnlock();
   emit docChanged();