[Kst] kdeextragear-2/kst/kst
George Staikos
staikos at kde.org
Thu Aug 12 22:50:11 CEST 2004
CVS commit by staikos:
correct locking for the edit case
CCMAIL: 87013-done at bugs.kde.org
M +1 -4 kstplugindialog_i.cpp 1.82
--- kdeextragear-2/kst/kst/kstplugindialog_i.cpp #1.81:1.82
@@ -456,18 +456,16 @@ bool KstPluginDialogI::edit_I() {
DP->inputScalars().clear();
- DP->writeUnlock();
// Save the vectors and scalars
if (!saveInputs(DP, pPtr)) {
KMessageBox::sorry(this, i18n("There is an error in the plugin you "
"entered. Please fix it."));
+ DP->writeUnlock();
return false;
}
- DP->writeLock();
if (pitem >= 0 && PluginCombo->count() > 0) {
DP->setPlugin(pPtr);
}
- DP->writeUnlock();
if (!saveOutputs(DP, pPtr)) {
KMessageBox::sorry(this, i18n("There is an error in the plugin you "
@@ -476,5 +474,4 @@ bool KstPluginDialogI::edit_I() {
}
- DP->writeLock();
if (!DP->isValid()) {
KMessageBox::sorry(this, i18n("There is an error in the plugin you entered. Please fix it."));
More information about the Kst
mailing list