[Kst] kst_oldview_branch: kdeextragear-2/kst/kst

George Staikos staikos at kde.org
Fri Apr 23 04:15:32 CEST 2004


I don't think this commit is correct.  It's now impossible to resize an object 
non-recursively.  Meanwhile we could easily get recursive behaviour in 
parentResized() by calling parentResized() instead of updateFromAspect() on 
each child.  I think that's the correct approach.

Also, please dont' backport commits to the new view code.  The branch is 
supposed to only contain non-viewmode related fixes.  I will be disabling 
compile of this code in the branch.

On Thursday 22 April 2004 21:29, Andrew Walker wrote:
> CVS commit by arwalker:
>
> Make things truly recursive so we can resize deeper than one level.
>
>
>   M +10 -10    kstviewobject.cpp   1.27.2.1
>
>
> --- kdeextragear-2/kst/kst/kstviewobject.cpp  #1.27:1.27.2.1
> @@ -217,7 +217,4 @@ void KstViewObject::parentResized(const
>    Q_UNUSED(size)
>    updateFromAspect();
> -  for (KstViewObjectList::Iterator i = _children.begin(); i !=
> _children.end(); ++i) { -    (*i)->updateFromAspect();
> -  }
>  }
>
> @@ -454,11 +451,14 @@ void KstViewObject::lower() {
>
>  void KstViewObject::updateFromAspect() {
> -  if (!_parent) {
> -    return;
> -  }
> +  if (_parent) {
>    _geom.setX(_parent->geometry().left() + int(_aspect.x *
> _parent->geometry().width())); _geom.setY(_parent->geometry().top() +
> int(_aspect.y * _parent->geometry().height()));
> _geom.setRight(int(_geom.x() + _aspect.w * _parent->geometry().width()));
> _geom.setBottom(int(_geom.y() + _aspect.h * _parent->geometry().height()));
> +
> +    for (KstViewObjectList::Iterator i = _children.begin(); i !=
> _children.end(); ++i) { +      (*i)->updateFromAspect();
> +    }
> +  }
>  }
>
>
>
> _______________________________________________
> Kst mailing list
> Kst at kde.org
> https://mail.kde.org/mailman/listinfo/kst

-- 
George Staikos
KDE Developer				http://www.kde.org/
Staikos Computing Services Inc.		http://www.staikos.net/



More information about the Kst mailing list