[Kst] kdeextragear-2/kst/kst

[George Staikos]

On Wednesday 14 April 2004 12:22, Andrew Walker wrote:
> CVS commit by arwalker:
>
> Ensure that we don't add a NULL pointer to the exclusive list.
>
>
>   M +4 -1      kstobject.h   1.23
>
>
> --- kdeextragear-2/kst/kst/kstobject.h  #1.22:1.23
> @@ -159,5 +159,8 @@ void kstObjectSplitList(KstObjectList<Ks
>        inclusive.append(x);
>      } else {
> -      exclusive.append(x);
> +      T *y = dynamic_cast<T*>((*it).data());
> +      if (y != 0L) {
> +        exclusive.append(y);
> +      }
>      }
>    }

   This is unnecessary and should also be an assertion failure.  The first 
template argument is supposed to indicate the base type for the list, the 
second one is supposed to indicate the type to split out.  Your changes are 
telling me that there is something in KST::dataObjectList that doesn't 
inherit from KstDataObject, which is clearly a bug, and this again is only 
masking it.

-- 
George Staikos
KDE Developer				http://www.kde.org/
Staikos Computing Services Inc.		http://www.staikos.net/