[Kst] kdeextragear-2/kst/kst

[George Staikos]

On April 7, 2004 18:33, Andrew Walker wrote:
> --- kdeextragear-2/kst/kst/extensionmgr.cpp  #1.3:1.4
> @@ -30,5 +30,4 @@
>  #include <kservicetype.h>
>  #include <qstringlist.h>
> -#include <qmessagebox.h>
>
>  KStaticDeleter<ExtensionMgr> sd;
> @@ -76,5 +75,9 @@ ExtensionMgr::ExtensionMgr() : QObject()
>  ExtensionMgr::~ExtensionMgr() {
>    save();
> -  // FIXME: unregister any remaining extensions to avoid a crash
> +
> +  //
> +  // we do not need to explicitly delete any remaining
> +  //    extensions as they are handled automatically...
> +  //
>  }

  If I remember correctly, this FIXME is exactly the problem that you worked 
around in your previous commit by checking for app().  I'm not sure which is 
the correct way, but I think deleting them in the extension manager 
destructor will result in app() being always valid.  I'm also a bit worried 
about static destruction in this case.  It could create some funky 
crash-on-exit scenarios if we're not careful.

-- 
George Staikos
KDE Developer			http://www.kde.org/
Staikos Computing Services Inc.	http://www.staikos.net/